Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c957c943 authored by Takashi Iwai's avatar Takashi Iwai Committed by Greg Kroah-Hartman
Browse files

ALSA: line6: Zero-initialize message buffers 



[ Upstream commit c4e51e424e2c772ce1836912a8b0b87cd61bc9d5 ]

For shutting up spurious KMSAN uninit-value warnings, just replace
kmalloc() calls with kzalloc() for the buffers used for
communications.  There should be no real issue with the original code,
but it's still better to cover.

Reported-by: default avatar <syzbot+7fb05ccf7b3d2f9617b3@syzkaller.appspotmail.com>
Closes: https://lore.kernel.org/r/00000000000084b18706150bcca5@google.com


Message-ID: <20240402063628.26609-1-tiwai@suse.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 468f3e3c

sound/usb/line6/driver.c

+3 −3
Original line number Diff line number Diff line
@@ -216,7 +216,7 @@ int line6_send_raw_message_async(struct usb_line6 *line6, const char *buffer, 
	struct urb *urb;



	/* create message: */

	msg = kmalloc(sizeof(struct message), GFP_ATOMIC);

	msg = kzalloc(sizeof(struct message), GFP_ATOMIC);

	if (msg == NULL)

		return -ENOMEM;
@@ -694,7 +694,7 @@ static int line6_init_cap_control(struct usb_line6 *line6) 
	int ret;



	/* initialize USB buffers: */

	line6->buffer_listen = kmalloc(LINE6_BUFSIZE_LISTEN, GFP_KERNEL);

	line6->buffer_listen = kzalloc(LINE6_BUFSIZE_LISTEN, GFP_KERNEL);

	if (!line6->buffer_listen)

		return -ENOMEM;
@@ -703,7 +703,7 @@ static int line6_init_cap_control(struct usb_line6 *line6) 
		return -ENOMEM;



	if (line6->properties->capabilities & LINE6_CAP_CONTROL_MIDI) {

		line6->buffer_message = kmalloc(LINE6_MIDI_MESSAGE_MAXLEN, GFP_KERNEL);

		line6->buffer_message = kzalloc(LINE6_MIDI_MESSAGE_MAXLEN, GFP_KERNEL);

		if (!line6->buffer_message)

			return -ENOMEM;