Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c92eb77a authored by Roopa Prabhu's avatar Roopa Prabhu Committed by David S. Miller
Browse files

net-sysfs: trigger netlink notification on ifalias change via sysfs 



This patch adds netlink notifications on iflias changes via sysfs.
makes it consistent with the netlink path which also calls
netdev_state_change. Also makes it consistent with other sysfs
netdev_store operations.

Signed-off-by: default avatarRoopa Prabhu <roopa@cumulusnetworks.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6dc14dc4

net/core/net-sysfs.c

+14 −3
Original line number Diff line number Diff line
@@ -382,7 +382,7 @@ static ssize_t ifalias_store(struct device *dev, struct device_attribute *attr, 
	struct net_device *netdev = to_net_dev(dev);

	struct net *net = dev_net(netdev);

	size_t count = len;

	ssize_t ret;

	ssize_t ret = 0;



	if (!ns_capable(net->user_ns, CAP_NET_ADMIN))

		return -EPERM;
@@ -391,9 +391,20 @@ static ssize_t ifalias_store(struct device *dev, struct device_attribute *attr, 
	if (len >  0 && buf[len - 1] == '\n')

		--count;



	if (!rtnl_trylock())

		return restart_syscall();



	if (dev_isalive(netdev)) {

		ret = dev_set_alias(netdev, buf, count);

		if (ret < 0)

			goto err;

		ret = len;

		netdev_state_change(netdev);

	}

err:

	rtnl_unlock();



	return ret < 0 ? ret : len;

	return ret;

}



static ssize_t ifalias_show(struct device *dev,