Commit c9160b69 authored Apr 10, 2018 by Jia-Ju Bai Committed by Jon Mason Jun 11, 2018

ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_create_queue



ntb_transport_create_queue() is never called in atomic context.

ntb_transport_create_queue() is only called by ntb_netdev_probe(),
which is set as ".probe" in struct ntb_transport_client.

Despite never getting called from atomic context,
ntb_transport_create_queue() calls kzalloc_node() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>

parent 82edcc75

drivers/ntb/ntb_transport.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1828,7 +1828,7 @@ ntb_transport_create_queue(void data, struct device client_dev,
		qp->rx_dma_chan ? "DMA" : "CPU");

		for (i = 0; i < NTB_QP_DEF_NUM_ENTRIES; i++) {
		entry = kzalloc_node(sizeof(*entry), GFP_ATOMIC, node);
		entry = kzalloc_node(sizeof(*entry), GFP_KERNEL, node);
		if (!entry)
		goto err1;

		@@ -1839,7 +1839,7 @@ ntb_transport_create_queue(void data, struct device client_dev,
		qp->rx_alloc_entry = NTB_QP_DEF_NUM_ENTRIES;

		for (i = 0; i < qp->tx_max_entry; i++) {
		entry = kzalloc_node(sizeof(*entry), GFP_ATOMIC, node);
		entry = kzalloc_node(sizeof(*entry), GFP_KERNEL, node);
		if (!entry)
		goto err2;