Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7b4fee3 authored by Kenji Kaneshige's avatar Kenji Kaneshige Committed by Jesse Barnes
Browse files

PCI hotplug: pciehp: remove unnecessary wait after turning power off 



The pciehp driver waits for 1000 msec after turning power off to make
sure the power has been completely removed. But this 1000 msec wait is
not needed if a slot doesn't implement power control because software
cannot control the power. Power will be automatically removed at adapter
removal time on such a slot

Tested-by: default avatar"Phil Endecott" <phil_pibbu_endecott@chezphil.org>
Signed-off-by: default avatarKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent 9eff02e2

drivers/pci/hotplug/pciehp_ctrl.c

+12 −14
Original line number Diff line number Diff line
@@ -178,14 +178,13 @@ static void set_slot_off(struct controller *ctrl, struct slot * pslot) 
				 "Issue of Slot Power Off command failed\n");

			return;

		}

	}



		/*

		 * After turning power off, we must wait for at least 1 second

		 * before taking any action that relies on power having been

		 * removed from the slot/adapter.

		 */

		msleep(1000);

	}



	if (PWR_LED(ctrl))

		pslot->hpc_ops->green_led_off(pslot);
@@ -286,14 +285,13 @@ static int remove_board(struct slot *p_slot) 
				 "Issue of Slot Disable command failed\n");

			return retval;

		}

	}



		/*

		 * After turning power off, we must wait for at least 1 second

		 * before taking any action that relies on power having been

		 * removed from the slot/adapter.

		 */

		msleep(1000);

	}



	if (PWR_LED(ctrl))

		/* turn off Green LED */