Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c76a23da authored by Elina Pasheva's avatar Elina Pasheva Committed by Greg Kroah-Hartman
Browse files

USB: serial: sierra driver interrupt urb resubmit fix 



- Fixed a problem when re-submitting urb from interrupt callback in
  function sierra_instat_callback(). This suppresses also issuing of
  error messages in /var/log/kern.log
- Removed redundant debug message at the beginning of
  sierra_instat_callback() function
- Changed a debug message to be an error message

Signed-off-by: default avatarElina Pasheva <epasheva@sierrawireless.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 238ebd13

drivers/usb/serial/sierra.c

+3 −4
Original line number Diff line number Diff line
@@ -556,7 +556,6 @@ static void sierra_instat_callback(struct urb *urb) 
	struct sierra_port_private *portdata = usb_get_serial_port_data(port);

	struct usb_serial *serial = port->serial;



	dev_dbg(&port->dev, "%s\n", __func__);

	dev_dbg(&port->dev, "%s: urb %p port %p has data %p\n", __func__,

		urb, port, portdata);
@@ -600,11 +599,11 @@ static void sierra_instat_callback(struct urb *urb) 
		dev_dbg(&port->dev, "%s: error %d\n", __func__, status);



	/* Resubmit urb so we continue receiving IRQ data */

	if (status != -ESHUTDOWN) {

	if (port->port.count && status != -ESHUTDOWN && status != -ENOENT) {

		urb->dev = serial->dev;

		err = usb_submit_urb(urb, GFP_ATOMIC);

		if (err)

			dev_dbg(&port->dev, "%s: resubmit intr urb "

			dev_err(&port->dev, "%s: resubmit intr urb "

				"failed. (%d)\n", __func__, err);

	}

}