Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7673e4d authored by Arnd Bergmann's avatar Arnd Bergmann Committed by David S. Miller
Browse files

vmxnet3: avoid format strint overflow warning 



gcc-7 notices that "-event-%d" could be more than 11 characters long
if we had larger 'vector' numbers:

drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev':
drivers/net/vmxnet3/vmxnet3_drv.c:2095:40: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=]
sprintf(intr->event_msi_vector_name, "%s-event-%d",
                                     ^~~~~~~~~~~~~
drivers/net/vmxnet3/vmxnet3_drv.c:2095:3: note: 'sprintf' output between 9 and 33 bytes into a destination of size 32

The current code is safe, but making the string a little longer
is harmless and lets gcc see that it's ok.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c41626ce

drivers/net/vmxnet3/vmxnet3_int.h

+1 −1
Original line number Diff line number Diff line
@@ -311,7 +311,7 @@ struct vmxnet3_intr { 
	u8  num_intrs;			/* # of intr vectors */

	u8  event_intr_idx;		/* idx of the intr vector for event */

	u8  mod_levels[VMXNET3_LINUX_MAX_MSIX_VECT]; /* moderation level */

	char	event_msi_vector_name[IFNAMSIZ+11];

	char	event_msi_vector_name[IFNAMSIZ+17];

#ifdef CONFIG_PCI_MSI

	struct msix_entry msix_entries[VMXNET3_LINUX_MAX_MSIX_VECT];

#endif