Commit c72acf69 authored Oct 22, 2014 by SF Markus Elfring Committed by Joerg Roedel Oct 23, 2014

iommu/msm: Deletion of unnecessary checks before clk_disable()

A semantic patch approach was proposed with the subject
"[PATCH with Coccinelle?] Deletion of unnecessary checks
before specific function calls" on 2014-03-05.
https://lkml.org/lkml/2014/3/5/344
http://article.gmane.org/gmane.comp.version-control.coccinelle/3513/



This patch pattern application was repeated with the help of
the software "Coccinelle 1.0.0-rc22" on the source files for
Linux 3.17.1. An extract of the automatically generated
update suggestions is shown here.

It was determined that the affected source code places call
functions which perform input parameter validation already.
It is therefore not needed that a similar safety check is
repeated at the call site.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent f114040e

drivers/iommu/msm_iommu.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -73,7 +73,6 @@ static int __enable_clocks(struct msm_iommu_drvdata *drvdata)

		static void __disable_clocks(struct msm_iommu_drvdata *drvdata)
		{
		if (drvdata->clk)
		clk_disable(drvdata->clk);
		clk_disable(drvdata->pclk);
		}

drivers/iommu/msm_iommu_dev.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -224,7 +224,6 @@ static int msm_iommu_probe(struct platform_device *pdev)

		platform_set_drvdata(pdev, drvdata);

		if (iommu_clk)
		clk_disable(iommu_clk);

		clk_disable(iommu_pclk);
		@@ -323,7 +322,6 @@ static int msm_iommu_ctx_probe(struct platform_device *pdev)
		SET_NSCFG(drvdata->base, mid, 3);
		}

		if (drvdata->clk)
		clk_disable(drvdata->clk);
		clk_disable(drvdata->pclk);