Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6f92f9f authored by Mel Gorman's avatar Mel Gorman Committed by Linus Torvalds
Browse files

mm: remove cold parameter for release_pages 

All callers of release_pages claim the pages being released are cache
hot.  As no one cares about the hotness of pages being released to the
allocator, just ditch the parameter.

No performance impact is expected as the overhead is marginal.  The
parameter is removed simply because it is a bit stupid to have a useless
parameter copied everywhere.

Link: http://lkml.kernel.org/r/20171018075952.10627-7-mgorman@techsingularity.net


Signed-off-by: default avatarMel Gorman <mgorman@techsingularity.net>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 86679820

drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

+2 −4
Original line number Diff line number Diff line
@@ -553,8 +553,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, 
				 * invalidated it. Free it and try again

				 */

				release_pages(e->user_pages,

					      e->robj->tbo.ttm->num_pages,

					      false);

					      e->robj->tbo.ttm->num_pages);

				kvfree(e->user_pages);

				e->user_pages = NULL;

			}
@@ -691,8 +690,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, 
				continue;



			release_pages(e->user_pages,

				      e->robj->tbo.ttm->num_pages,

				      false);

				      e->robj->tbo.ttm->num_pages);

			kvfree(e->user_pages);

		}

	}

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

+1 −1
Original line number Diff line number Diff line
@@ -347,7 +347,7 @@ int amdgpu_gem_userptr_ioctl(struct drm_device *dev, void *data, 
	return 0;



free_pages:

	release_pages(bo->tbo.ttm->pages, bo->tbo.ttm->num_pages, false);

	release_pages(bo->tbo.ttm->pages, bo->tbo.ttm->num_pages);



unlock_mmap_sem:

	up_read(&current->mm->mmap_sem);

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

+1 −1
Original line number Diff line number Diff line
@@ -659,7 +659,7 @@ int amdgpu_ttm_tt_get_user_pages(struct ttm_tt *ttm, struct page **pages) 
	return 0;



release_pages:

	release_pages(pages, pinned, 0);

	release_pages(pages, pinned);

	return r;

}

drivers/gpu/drm/etnaviv/etnaviv_gem.c

+3 −3
Original line number Diff line number Diff line
@@ -779,7 +779,7 @@ static struct page **etnaviv_gem_userptr_do_get_pages( 
	up_read(&mm->mmap_sem);



	if (ret < 0) {

		release_pages(pvec, pinned, 0);

		release_pages(pvec, pinned);

		kvfree(pvec);

		return ERR_PTR(ret);

	}
@@ -852,7 +852,7 @@ static int etnaviv_gem_userptr_get_pages(struct etnaviv_gem_object *etnaviv_obj) 
		}

	}



	release_pages(pvec, pinned, 0);

	release_pages(pvec, pinned);

	kvfree(pvec);



	work = kmalloc(sizeof(*work), GFP_KERNEL);
@@ -886,7 +886,7 @@ static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj) 
	if (etnaviv_obj->pages) {

		int npages = etnaviv_obj->base.size >> PAGE_SHIFT;



		release_pages(etnaviv_obj->pages, npages, 0);

		release_pages(etnaviv_obj->pages, npages);

		kvfree(etnaviv_obj->pages);

	}

	put_task_struct(etnaviv_obj->userptr.task);

drivers/gpu/drm/i915/i915_gem_userptr.c

+2 −2
Original line number Diff line number Diff line
@@ -554,7 +554,7 @@ __i915_gem_userptr_get_pages_worker(struct work_struct *_work) 
	}

	mutex_unlock(&obj->mm.lock);



	release_pages(pvec, pinned, 0);

	release_pages(pvec, pinned);

	kvfree(pvec);



	i915_gem_object_put(obj);
@@ -668,7 +668,7 @@ i915_gem_userptr_get_pages(struct drm_i915_gem_object *obj) 
		__i915_gem_userptr_set_active(obj, true);



	if (IS_ERR(pages))

		release_pages(pvec, pinned, 0);

		release_pages(pvec, pinned);

	kvfree(pvec);



	return pages;