Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6d20ab4 authored by Dirk van der Merwe's avatar Dirk van der Merwe Committed by David S. Miller
Browse files

nfp: flower: obtain repr link state only from firmware 



Instead of starting up reprs assuming that there is link, only respond
to the link state reported by firmware.

Furthermore, ensure link is down after repr netdevs are created.

Signed-off-by: default avatarDirk van der Merwe <dirk.vandermerwe@netronome.com>
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ee7e16b6

drivers/net/ethernet/netronome/nfp/flower/main.c

+0 −2
Original line number Diff line number Diff line
@@ -110,7 +110,6 @@ nfp_flower_repr_netdev_open(struct nfp_app *app, struct nfp_repr *repr) 
	if (err)

		return err;



	netif_carrier_on(repr->netdev);

	netif_tx_wake_all_queues(repr->netdev);



	return 0;
@@ -119,7 +118,6 @@ nfp_flower_repr_netdev_open(struct nfp_app *app, struct nfp_repr *repr) 
static int

nfp_flower_repr_netdev_stop(struct nfp_app *app, struct nfp_repr *repr)

{

	netif_carrier_off(repr->netdev);

	netif_tx_disable(repr->netdev);



	return nfp_flower_cmsg_portmod(repr, false);

drivers/net/ethernet/netronome/nfp/nfp_net_repr.c

+2 −0
Original line number Diff line number Diff line
@@ -336,6 +336,8 @@ struct net_device *nfp_repr_alloc(struct nfp_app *app) 
	if (!netdev)

		return NULL;



	netif_carrier_off(netdev);



	repr = netdev_priv(netdev);

	repr->netdev = netdev;

	repr->app = app;