Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6cc9fc9 authored by Syam Sidhardhan's avatar Syam Sidhardhan Committed by Anton Vorontsov
Browse files

s3c-adc-battery: Fix possible NULL pointer dereference



Check for (bat == NULL) has to be done before accessing bat

Signed-off-by: default avatarSyam Sidhardhan <s.syam@samsung.com>
Signed-off-by: default avatarAnton Vorontsov <anton@enomsg.org>
parent 9239ebcf
Loading
Loading
Loading
Loading
+5 −2
Original line number Diff line number Diff line
@@ -145,14 +145,17 @@ static int s3c_adc_bat_get_property(struct power_supply *psy,

	int new_level;
	int full_volt;
	const struct s3c_adc_bat_thresh *lut = bat->pdata->lut_noac;
	unsigned int lut_size = bat->pdata->lut_noac_cnt;
	const struct s3c_adc_bat_thresh *lut;
	unsigned int lut_size;

	if (!bat) {
		dev_err(psy->dev, "no battery infos ?!\n");
		return -EINVAL;
	}

	lut = bat->pdata->lut_noac;
	lut_size = bat->pdata->lut_noac_cnt;

	if (bat->volt_value < 0 || bat->cur_value < 0 ||
		jiffies_to_msecs(jiffies - bat->timestamp) >
			BAT_POLL_INTERVAL) {