Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c613d061 authored by Akinobu Mita's avatar Akinobu Mita Committed by James Bottomley
Browse files

[SCSI] scsi_debug: fix duplicate dif_errors increment 



It is unnecessary to increase dif_errors in dif_verify(), because the
caller will increment it when dif_verify() detects failure.

This bug was introduced by commit beb40ea4 ("[SCSI] scsi_debug:
reduce duplication between prot_verify_read and prot_verify_write")

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Acked-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 11ddceca

drivers/scsi/scsi_debug.c

+0 −1
Original line number Diff line number Diff line
@@ -1780,7 +1780,6 @@ static int dif_verify(struct sd_dif_tuple *sdt, const void *data, 
	    be32_to_cpu(sdt->ref_tag) != ei_lba) {

		pr_err("%s: REF check failed on sector %lu\n",

			__func__, (unsigned long)sector);

			dif_errors++;

		return 0x03;

	}

	return 0;