Commit c5fb85b7 authored May 29, 2018 by Christoph Hellwig Committed by Jens Axboe May 29, 2018

mtip32xx: complete requests from ->timeout



By completing the request entirely in the driver we can remove the
BLK_EH_HANDLED return value and thus the split responsibility between the
driver and the block layer that has been causing trouble.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent e5eab017

drivers/block/mtip32xx/mtip32xx.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3719,7 +3719,8 @@ static enum blk_eh_timer_return mtip_cmd_timeout(struct request *req,
		struct mtip_cmd *cmd = blk_mq_rq_to_pdu(req);

		cmd->status = BLK_STS_TIMEOUT;
		return BLK_EH_HANDLED;
		blk_mq_complete_request(req);
		return BLK_EH_DONE;
		}

		if (test_bit(req->tag, dd->port->cmds_to_issue))