Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5bee2da authored by Ashok Vuyyuru's avatar Ashok Vuyyuru Committed by Gerrit - the friendly Code Review server
Browse files

Revert "msm: ipa4: debug patch gsi interrupt issue" 



Removing the debug changes added as part of commit
76a8b953 causing more
crashes.

Signed-off-by: default avatarAshok Vuyyuru <avuyyuru@codeaurora.org>
Change-Id: I8654a04be35d46101072391bee7a67741ebbbf13
parent bd01dd40

drivers/platform/msm/gsi/gsi.c

+0 −7
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ 
#define GSI_CMD_POLL_CNT 5

#define GSI_STOP_CMD_TIMEOUT_MS 200

#define GSI_MAX_CH_LOW_WEIGHT 15

#define GSI_IRQ_STORM_THR 5



#define GSI_STOP_CMD_POLL_CNT 4

#define GSI_STOP_IN_PROC_CMD_POLL_CNT 2
@@ -809,14 +808,8 @@ static irqreturn_t gsi_isr(int irq, void *ctxt) 
			gsi_ctx->per.rel_clk_cb(gsi_ctx->per.user_data);

		}

	} else if (!gsi_ctx->per.clk_status_cb()) {

	/* we only want to capture the gsi isr storm here */

		if (atomic_read(&gsi_ctx->num_unclock_irq) ==

			GSI_IRQ_STORM_THR)

			gsi_ctx->per.enable_clk_bug_on();

		atomic_inc(&gsi_ctx->num_unclock_irq);

		return IRQ_HANDLED;

	} else {

		atomic_set(&gsi_ctx->num_unclock_irq, 0);

		gsi_handle_irq();

	}

	return IRQ_HANDLED;

drivers/platform/msm/gsi/gsi.h

+0 −2
Original line number Diff line number Diff line
@@ -237,8 +237,6 @@ struct gsi_ctx { 
	u32 intcntrlr_mem_size;

	irq_handler_t intcntrlr_gsi_isr;

	irq_handler_t intcntrlr_client_isr;



	atomic_t num_unclock_irq;

};



enum gsi_re_type {

drivers/platform/msm/ipa/ipa_v3/ipa.c

+0 −18
Original line number Diff line number Diff line
@@ -124,10 +124,6 @@ static void ipa_dec_clients_disable_clks_on_wq(struct work_struct *work); 
static DECLARE_DELAYED_WORK(ipa_dec_clients_disable_clks_on_wq_work,

	ipa_dec_clients_disable_clks_on_wq);



static void ipa_inc_clients_enable_clks_on_wq(struct work_struct *work);

static DECLARE_WORK(ipa_inc_clients_enable_clks_on_wq_work,

	ipa_inc_clients_enable_clks_on_wq);



static int ipa3_ioctl_add_rt_rule_v2(unsigned long arg);

static int ipa3_ioctl_add_rt_rule_ext_v2(unsigned long arg);

static int ipa3_ioctl_add_rt_rule_after_v2(unsigned long arg);
@@ -5035,12 +5031,6 @@ void ipa3_inc_client_enable_clks(struct ipa_active_client_logging_info *id) 
	mutex_unlock(&ipa3_ctx->ipa3_active_clients.mutex);

}



void ipa3_handle_gsi_differ_irq(void)

{

	queue_work(ipa3_ctx->power_mgmt_wq,

		&ipa_inc_clients_enable_clks_on_wq_work);

}



/**

 * ipa3_active_clks_status() - update the current msm bus clock vote

 * status
@@ -5157,13 +5147,6 @@ static void ipa_dec_clients_disable_clks_on_wq(struct work_struct *work) 
	__ipa3_dec_client_disable_clks();

}



static void ipa_inc_clients_enable_clks_on_wq(struct work_struct *work)

{

	ipa3_enable_clks();

	IPAERR("unexpected clk access, clock on IPA to save reg");

	ipa_assert();

}



/**

 * ipa3_dec_client_disable_clks_no_block() - Decrease active clients counter

 * if possible without blocking. If this is the last client then the desrease
@@ -5959,7 +5942,6 @@ static int ipa3_post_init(const struct ipa3_plat_drv_res *resource_p, 
	gsi_props.req_clk_cb = NULL;

	gsi_props.rel_clk_cb = NULL;

	gsi_props.clk_status_cb = ipa3_active_clks_status;

	gsi_props.enable_clk_bug_on = ipa3_handle_gsi_differ_irq;



	if (ipa3_ctx->ipa_config_is_mhi) {

		gsi_props.mhi_er_id_limits_valid = true;

include/linux/msm_gsi.h

+0 −2
Original line number Diff line number Diff line
@@ -97,7 +97,6 @@ enum gsi_intr_type { 
 * @rel_clk_cb: callback to release peripheral clock

 * @user_data:  cookie used for notifications

 * @clk_status_cb: callback to update the current msm bus clock vote

 * @enable_clk_bug_on: enable IPA clock for dump saving before assert

 * @skip_ieob_mask_wa: flag for skipping ieob_mask_wa

 * All the callbacks are in interrupt context

 *
@@ -121,7 +120,6 @@ struct gsi_per_props { 
	int (*rel_clk_cb)(void *user_data);

	void *user_data;

	int (*clk_status_cb)(void);

	void (*enable_clk_bug_on)(void);

	bool skip_ieob_mask_wa;

};