Commit c4aec310 authored Feb 25, 2016 by Dan Carpenter Committed by Alex Williamson Feb 25, 2016

vfio/pci: return -EFAULT if copy_to_user fails

The copy_to_user() function returns the number of bytes that were not
copied but we want to return -EFAULT on error here.

Fixes: 188ad9d6 ('vfio/pci: Include sparse mmap capability for MSI-X table regions')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

parent a13b6459

drivers/vfio/pci/vfio_pci.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -664,12 +664,11 @@ static long vfio_pci_ioctl(void *device_data,
		info.cap_offset = 0;
		} else {
		vfio_info_cap_shift(&caps, sizeof(info));
		ret = copy_to_user((void __user *)arg +
		if (copy_to_user((void __user *)arg +
		sizeof(info), caps.buf,
		caps.size);
		if (ret) {
		caps.size)) {
		kfree(caps.buf);
		return ret;
		return -EFAULT;
		}
		info.cap_offset = sizeof(info);
		}