Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c45eabec authored by Akinobu Mita's avatar Akinobu Mita Committed by James Bottomley
Browse files

[SCSI] scsi_debug: fix false positive logical block reference tag check fail 



Reading partially unwritten sectors generates a false positive logical
block reference tag check failure when DIF is enabled.

This bug is caused by missing ei_lba increment in loop of dif_verify()
when unwritten sector is skipped.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Acked-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 134997a0

drivers/scsi/scsi_debug.c

+1 −3
Original line number Diff line number Diff line
@@ -1832,7 +1832,7 @@ static int prot_verify_read(struct scsi_cmnd *SCpnt, sector_t start_sec, 
	struct sd_dif_tuple *sdt;

	sector_t sector;



	for (i = 0; i < sectors; i++) {

	for (i = 0; i < sectors; i++, ei_lba++) {

		int ret;



		sector = start_sec + i;
@@ -1846,8 +1846,6 @@ static int prot_verify_read(struct scsi_cmnd *SCpnt, sector_t start_sec, 
			dif_errors++;

			return ret;

		}



		ei_lba++;

	}



	dif_copy_prot(SCpnt, start_sec, sectors, true);