Commit c4111041 authored Jul 04, 2018 by Dan Carpenter Committed by Jeff Kirsher Jul 12, 2018

ixgbe: Off by one in ixgbe_ipsec_tx()



The ipsec->tx_tbl[] has IXGBE_IPSEC_MAX_SA_COUNT elements so the > needs
to be changed to >= so we don't read one element beyond the end of the
array.

Fixes: 59259470 ("ixgbe: process the Tx ipsec offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Shannon Nelson <shannon.nelson@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent d14c780c

drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -839,7 +839,7 @@ int ixgbe_ipsec_tx(struct ixgbe_ring *tx_ring,
		}

		itd->sa_idx = xs->xso.offload_handle - IXGBE_IPSEC_BASE_TX_INDEX;
		if (unlikely(itd->sa_idx > IXGBE_IPSEC_MAX_SA_COUNT)) {
		if (unlikely(itd->sa_idx >= IXGBE_IPSEC_MAX_SA_COUNT)) {
		netdev_err(tx_ring->netdev, "%s: bad sa_idx=%d handle=%lu\n",
		__func__, itd->sa_idx, xs->xso.offload_handle);
		return 0;