Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c408aac3 authored by Marc Zyngier's avatar Marc Zyngier Committed by Greg Kroah-Hartman
Browse files

PCI: dwc: Take lock when ACKing an interrupt 

commit fce5423e4f431c71933d6c1f850b540a314aa6ee upstream.

Bizarrely, there is no lock taken in the irq_ack() helper. This
puts the ACK callback provided by a specific platform in a awkward
situation where there is no synchronization that would be expected
on other callback.

Introduce the required lock, giving some level of uniformity among
callbacks.

Fixes: 7c5925af ("PCI: dwc: Move MSI IRQs allocation to IRQ domains
hierarchical API")
Link: https://lore.kernel.org/linux-pci/20181113225734.8026-1-marc.zyngier@arm.com/


Tested-by: default avatarNiklas Cassel <niklas.cassel@linaro.org>
Tested-by: default avatarGustavo Pimentel <gustavo.pimentel@synopsys.com>
Tested-by: default avatarStanimir Varbanov <svarbanov@mm-sol.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 11637a3a

drivers/pci/controller/dwc/pcie-designware-host.c

+5 −0
Original line number Diff line number Diff line
@@ -202,11 +202,16 @@ static void dw_pci_bottom_ack(struct irq_data *d) 
{

	struct msi_desc *msi = irq_data_get_msi_desc(d);

	struct pcie_port *pp;

	unsigned long flags;



	pp = msi_desc_to_pci_sysdata(msi);



	raw_spin_lock_irqsave(&pp->lock, flags);



	if (pp->ops->msi_irq_ack)

		pp->ops->msi_irq_ack(d->hwirq, pp);



	raw_spin_unlock_irqrestore(&pp->lock, flags);

}



static struct irq_chip dw_pci_msi_bottom_irq_chip = {