Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3f27a26 authored by Lee Jones's avatar Lee Jones
Browse files

mfd: ab8500-debugfs: Simplify invalid debugfs data checking 



Noticed during a coding review, if we reorganised the checking a
little, we can rid the code of a pointless 'else'.  Whilst looking
for this particular code hunk I noticed another pointless 'else',
which I've subsequently fixed in this patch.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent f3556302

drivers/mfd/ab8500-debugfs.c

+7 −7
Original line number Diff line number Diff line
@@ -2503,14 +2503,14 @@ static ssize_t ab8500_gpadc_trig_timer_write(struct file *file, 
	if (err)

		return err;



	if (user_trig_timer <= 255) {

		trig_timer = (u8) user_trig_timer;

	} else {

		dev_err(dev, "debugfs error input: "

			"should be beetween 0 to 255\n");

	if (user_trig_timer & ~0xFF) {

		dev_err(dev,

			"debugfs error input: should be beetween 0 to 255\n");

		return -EINVAL;

	}



	trig_timer = (u8) user_trig_timer;



	return count;

}
@@ -2764,7 +2764,7 @@ static ssize_t show_irq(struct device *dev, 
	irq_index = name - irq_first;

	if (irq_index >= num_irqs)

		return -EINVAL;

	else



	return sprintf(buf, "%u\n", irq_count[irq_index]);

}