Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c365e59d authored by Kim, Milo's avatar Kim, Milo Committed by Linus Torvalds
Browse files

backlight: lp855x: remove duplicate platform data 



The 'load_new_rom_data' was used for checking whether new ROM data should
be updated or not.

However, we can decide it with 'size_program' data.  If the size is
greater than 0, it means updating ROM area is required.  Otherwise, the
default ROM data will be used.  Therefore, this duplicate platform data
can be removed.

Signed-off-by: default avatarMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 98e35be2

Documentation/backlight/lp855x-driver.txt

+0 −4
Original line number Diff line number Diff line
@@ -36,9 +36,6 @@ For supporting platform specific data, the lp855x platform data can be used. 
* initial_brightness : Initial value of backlight brightness.

* period_ns : Platform specific PWM period value. unit is nano.

	     Only valid when brightness is pwm input mode.

* load_new_rom_data :

	0 : use default configuration data

	1 : update values of eeprom or eprom registers on loading driver

* size_program : Total size of lp855x_rom_data.

* rom_data : List of new eeprom/eprom registers.
@@ -55,7 +52,6 @@ static struct lp855x_platform_data lp8552_pdata = { 
	.name = "lcd-bl",

	.device_control = I2C_CONFIG(LP8552),

	.initial_brightness = INITIAL_BRT,

	.load_new_rom_data = 1,

	.size_program = ARRAY_SIZE(lp8552_eeprom_arr),

	.rom_data = lp8552_eeprom_arr,

};

drivers/video/backlight/lp855x_bl.c

+1 −1
Original line number Diff line number Diff line
@@ -192,7 +192,7 @@ static int lp855x_configure(struct lp855x *lp) 
	if (ret)

		goto err;



	if (pd->load_new_rom_data && pd->size_program) {

	if (pd->size_program > 0) {

		for (i = 0; i < pd->size_program; i++) {

			addr = pd->rom_data[i].addr;

			val = pd->rom_data[i].val;

include/linux/platform_data/lp855x.h

+0 −4
Original line number Diff line number Diff line
@@ -115,9 +115,6 @@ struct lp855x_rom_data { 
 * @initial_brightness : initial value of backlight brightness

 * @period_ns : platform specific pwm period value. unit is nano.

		Only valid when mode is PWM_BASED.

 * @load_new_rom_data :

	0 : use default configuration data

	1 : update values of eeprom or eprom registers on loading driver

 * @size_program : total size of lp855x_rom_data

 * @rom_data : list of new eeprom/eprom registers

 */
@@ -126,7 +123,6 @@ struct lp855x_platform_data { 
	u8 device_control;

	u8 initial_brightness;

	unsigned int period_ns;

	u8 load_new_rom_data;

	int size_program;

	struct lp855x_rom_data *rom_data;

};