Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3563c3e authored by Wen Yang's avatar Wen Yang Committed by Greg Kroah-Hartman
Browse files

i2c: core: fix use after free in of_i2c_notify 



[ Upstream commit a4c2fec16f5e6a5fee4865e6e0e91e2bc2d10f37 ]

We can't use "adap->dev" after it has been freed.

Fixes: 5bf4fa7d ("i2c: break out OF support into separate file")
Signed-off-by: default avatarWen Yang <wenyang@linux.alibaba.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d228e1e3

drivers/i2c/i2c-core-of.c

+2 −2
Original line number Diff line number Diff line
@@ -253,14 +253,14 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action, 
		}



		client = of_i2c_register_device(adap, rd->dn);

		put_device(&adap->dev);



		if (IS_ERR(client)) {

			dev_err(&adap->dev, "failed to create client for '%pOF'\n",

				 rd->dn);

			put_device(&adap->dev);

			of_node_clear_flag(rd->dn, OF_POPULATED);

			return notifier_from_errno(PTR_ERR(client));

		}

		put_device(&adap->dev);

		break;

	case OF_RECONFIG_CHANGE_REMOVE:

		/* already depopulated? */