Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c32fb9e7 authored by Jonathan Brassow's avatar Jonathan Brassow Committed by NeilBrown
Browse files

DM RAID: Use md_error() in place of simply setting Faulty bit 



When encountering an error while reading the superblock, call md_error.

We are currently setting the 'Faulty' bit on one of the array devices when an
error is encountered while reading the superblock of a dm-raid array.  We should
be calling md_error(), as it handles the error more completely.

Signed-off-by: default avatarJonathan Brassow <jbrassow@redhat.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 81f382f9

drivers/md/dm-raid.c

+1 −1
Original line number Diff line number Diff line
@@ -603,7 +603,7 @@ static int read_disk_sb(struct md_rdev *rdev, int size) 
	if (!sync_page_io(rdev, 0, size, rdev->sb_page, READ, 1)) {

		DMERR("Failed to read superblock of device at position %d",

		      rdev->raid_disk);

		set_bit(Faulty, &rdev->flags);

		md_error(rdev->mddev, rdev);

		return -EINVAL;

	}