Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c32b8dcc authored by Matt Reimer's avatar Matt Reimer Committed by David Woodhouse
Browse files

[MTD] [NAND] treat any negative return value from correct() as an error 



Treat any negative return value from a NAND driver's correct() function
as a failure, rather than just -1.

Signed-off-by: default avatarMatt Reimer <mreimer@vpop.net>
Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
parent 39e73fc1

drivers/mtd/nand/nand_base.c

+3 −3
Original line number Diff line number Diff line
@@ -789,7 +789,7 @@ static int nand_read_page_swecc(struct mtd_info *mtd, struct nand_chip *chip, 
		int stat;



		stat = chip->ecc.correct(mtd, p, &ecc_code[i], &ecc_calc[i]);

		if (stat == -1)

		if (stat < 0)

			mtd->ecc_stats.failed++;

		else

			mtd->ecc_stats.corrected += stat;
@@ -833,7 +833,7 @@ static int nand_read_page_hwecc(struct mtd_info *mtd, struct nand_chip *chip, 
		int stat;



		stat = chip->ecc.correct(mtd, p, &ecc_code[i], &ecc_calc[i]);

		if (stat == -1)

		if (stat < 0)

			mtd->ecc_stats.failed++;

		else

			mtd->ecc_stats.corrected += stat;
@@ -874,7 +874,7 @@ static int nand_read_page_syndrome(struct mtd_info *mtd, struct nand_chip *chip, 
		chip->read_buf(mtd, oob, eccbytes);

		stat = chip->ecc.correct(mtd, p, oob, NULL);



		if (stat == -1)

		if (stat < 0)

			mtd->ecc_stats.failed++;

		else

			mtd->ecc_stats.corrected += stat;