Commit c21a493a authored Nov 22, 2016 by Ravi Bangoria Committed by Michael Ellerman Feb 15, 2017

powerpc/xmon: Fix data-breakpoint



Currently xmon data-breakpoint feature is broken.

Whenever there is a watchpoint match occurs, hw_breakpoint_handler will
be called by do_break via notifier chains mechanism. If watchpoint is
registered by xmon, hw_breakpoint_handler won't find any associated
perf_event and returns immediately with NOTIFY_STOP. Similarly, do_break
also returns without notifying to xmon.

Solve this by returning NOTIFY_DONE when hw_breakpoint_handler does not
find any perf_event associated with matched watchpoint, rather than
NOTIFY_STOP, which tells the core code to continue calling the other
breakpoint handlers including the xmon one.

Cc: stable@vger.kernel.org
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 36b390fd

arch/powerpc/kernel/hw_breakpoint.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -228,8 +228,10 @@ int hw_breakpoint_handler(struct die_args *args)
		rcu_read_lock();

		bp = __this_cpu_read(bp_per_reg);
		if (!bp)
		if (!bp) {
		rc = NOTIFY_DONE;
		goto out;
		}
		info = counter_arch_bp(bp);

		/*