Commit c1c2f8bb authored Jul 19, 2020 by Tom Rix Committed by Greg Kroah-Hartman Oct 29, 2020

media: m5mols: Check function pointer in m5mols_sensor_power



[ Upstream commit 52438c4463ac904d14bf3496765e67750766f3a6 ]

clang static analysis reports this error

m5mols_core.c:767:4: warning: Called function pointer
  is null (null dereference) [core.CallAndMessage]
    info->set_power(&client->dev, 0);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In other places, the set_power ptr is checked.
So add a check.

Fixes: bc125106 ("[media] Add support for M-5MOLS 8 Mega Pixel camera ISP")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d81bfffb

drivers/media/i2c/m5mols/m5mols_core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -768,6 +768,7 @@ static int m5mols_sensor_power(struct m5mols_info *info, bool enable)

		ret = regulator_bulk_enable(ARRAY_SIZE(supplies), supplies);
		if (ret) {
		if (info->set_power)
		info->set_power(&client->dev, 0);
		return ret;
		}