Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1aa0c84 authored by YueHaibing's avatar YueHaibing Committed by Greg Kroah-Hartman
Browse files

video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data" 



commit 2607391882fca37463187e7f2a9c76dec286947e upstream.

'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display.

This gives this error message:
  ./drivers/video/fbdev/pxafb.c:2238:2-7: WARNING: invalid free of devm_ allocated data

Fixes: c8f96304 ("video: fbdev: pxafb: switch to devm_* API")
Cc: stable@kernel.org [v4.19+]
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarDaniel Mack <daniel@zonque.org>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9797226b

drivers/video/fbdev/pxafb.c

+1 −3
Original line number Diff line number Diff line
@@ -2234,10 +2234,8 @@ static struct pxafb_mach_info *of_pxafb_of_mach_info(struct device *dev) 
	if (!info)

		return ERR_PTR(-ENOMEM);

	ret = of_get_pxafb_mode_info(dev, info);

	if (ret) {

		kfree(info->modes);

	if (ret)

		return ERR_PTR(ret);

	}



	/*

	 * On purpose, neither lccrX registers nor video memory size can be