Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c14a7400 authored by Johannes Berg's avatar Johannes Berg
Browse files

cfg80211: ignore invalid BSSIDs when looking for BSSes



When looking for a BSS matching given parameters, ignore invalid
BSSIDs. This avoids, for example, trying to join an IBSS that has
a multicast BSSID, which isn't supported by all drivers nor is it
a valid configuration of the IBSS so better create a new one with
a correctly chosen random BSSID.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 74f82741
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -540,6 +540,8 @@ struct cfg80211_bss *cfg80211_get_bss(struct wiphy *wiphy,
			continue;
		if (channel && bss->pub.channel != channel)
			continue;
		if (!is_valid_ether_addr(bss->pub.bssid))
			continue;
		/* Don't get expired BSS structs */
		if (time_after(now, bss->ts + IEEE80211_SCAN_RESULT_EXPIRE) &&
		    !atomic_read(&bss->hold))