Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1288b83 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Jonathan Cameron
Browse files

iio: accel: kxcjk-1013: Increment ref counter for indio_dev->trig 

Assigning indio_dev->trig is not a good idea, as this can result in
wrong reference count for trigger device. If assigned, it is better to
increment reference counter by calling iio_trigger_get.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html

 for discussion
with Jonathan.

Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 59bfeaba

drivers/iio/accel/kxcjk-1013.c

+1 −0
Original line number Diff line number Diff line
@@ -644,6 +644,7 @@ static int kxcjk1013_probe(struct i2c_client *client, 
		iio_trigger_set_drvdata(trig, indio_dev);

		data->trig = trig;

		indio_dev->trig = trig;

		iio_trigger_get(indio_dev->trig);



		ret = iio_trigger_register(trig);

		if (ret)