Commit c0d934ba authored Sep 11, 2013 by Joonsoo Kim Committed by Linus Torvalds Sep 11, 2013

mm, hugetlb: remove redundant list_empty check in gather_surplus_pages()



If list is empty, list_for_each_entry_safe() doesn't do anything.  So,
this check is redundant.  Remove it.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Acked-by: Hillf Danton <dhillf@gmail.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Davidlohr Bueso <davidlohr.bueso@hp.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent b2261026

mm/hugetlb.c

+2 −5

Original line number	Original line	Diff line number	Diff line
	@@ -1037,11 +1037,8 @@ static int gather_surplus_pages(struct hstate *h, int delta)
	spin_unlock(&hugetlb_lock);		spin_unlock(&hugetlb_lock);

	/* Free unnecessary surplus pages to the buddy allocator */		/* Free unnecessary surplus pages to the buddy allocator */
	if (!list_empty(&surplus_list)) {		list_for_each_entry_safe(page, tmp, &surplus_list, lru)
	list_for_each_entry_safe(page, tmp, &surplus_list, lru) {
	put_page(page);		put_page(page);
	}
	}
	spin_lock(&hugetlb_lock);		spin_lock(&hugetlb_lock);

	return ret;		return ret;