Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0ab4242 authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

[PATCH] sil24: make error_intr less verbose 



sil24_error_intr logs all error interrupts.  ATAPI devices generates
many harmless errors which can be ignored and all serious ones are
reported via sense data by SCSI layer.  Don't log device errors from
ATAPI devices.

Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 69ad185f

drivers/scsi/sata_sil24.c

+9 −3
Original line number Diff line number Diff line
@@ -684,7 +684,13 @@ static void sil24_error_intr(struct ata_port *ap, u32 slot_stat) 
	if (serror)

		writel(serror, port + PORT_SERROR);



	printk(KERN_ERR DRV_NAME " ata%u: error interrupt on port%d\n"

	/*

	 * Don't log ATAPI device errors.  They're supposed to happen

	 * and any serious errors will be logged using sense data by

	 * the SCSI layer.

	 */

	if (ap->device[0].class != ATA_DEV_ATAPI || cmd_err > PORT_CERR_SDB)

		printk("ata%u: error interrupt on port%d\n"

		       "  stat=0x%x irq=0x%x cmd_err=%d sstatus=0x%x serror=0x%x\n",

		       ap->id, ap->port_no, slot_stat, irq_stat, cmd_err, sstatus, serror);