Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c07be136 authored by Sarah Bailey's avatar Sarah Bailey Committed by Greg Kroah-Hartman
Browse files

USB: Fixed bug in endpoint release function. 



Error handling in usb_create_ep_files() is not correct unless
the minor number is freed in ep_device_release().

Signed-off-by: default avatarSarah Bailey <saharabeara@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 684a0e70

drivers/usb/core/endpoint.c

+1 −1
Original line number Diff line number Diff line
@@ -268,6 +268,7 @@ static void ep_device_release(struct device *dev) 
	struct ep_device *ep_dev = to_ep_device(dev);



	dev_dbg(dev, "%s called for %s\n", __FUNCTION__, dev->bus_id);

	endpoint_free_minor(ep_dev);

	kfree(ep_dev);

}
@@ -349,7 +350,6 @@ void usb_remove_ep_files(struct usb_host_endpoint *endpoint) 
		sprintf(name, "ep_%02x", endpoint->desc.bEndpointAddress);

		sysfs_remove_link(&ep_dev->dev.parent->kobj, name);

		sysfs_remove_group(&ep_dev->dev.kobj, &ep_dev_attr_grp);

		endpoint_free_minor(ep_dev);

		device_unregister(&ep_dev->dev);

		endpoint->ep_dev = NULL;

		destroy_endpoint_class();