Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c04871e6 authored by J. Bruce Fields's avatar J. Bruce Fields Committed by Trond Myklebust
Browse files

NFSv4: remove obviously bogus comparison from decode_getacl 



We just set *acl_len to zero, and attrlen is unsigned, so this comparison
is clearly bogus.  I have no idea what I was thinking.

Fixes a bug that caused getacl to fail over krb5p.

Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 3873bc50

fs/nfs/nfs4xdr.c

+1 −2
Original line number Diff line number Diff line
@@ -3350,7 +3350,6 @@ static int decode_getacl(struct xdr_stream *xdr, struct rpc_rqst *req, 
					attrlen, recvd);

			return -EINVAL;

		}

		if (attrlen <= *acl_len)

		xdr_read_pages(xdr, attrlen);

		*acl_len = attrlen;

	} else