Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c044170f authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Mauro Carvalho Chehab
Browse files

[media] media: rc: nuvoton: replace usage of spin_lock_irqsave in ISR 



Kernel takes care that interrupts from one source are serialized.
So there's no need to use spinlock_irq_save.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 73d4576d

drivers/media/rc/nuvoton-cir.c

+4 −5
Original line number Diff line number Diff line
@@ -840,11 +840,10 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) 
{

	struct nvt_dev *nvt = data;

	u8 status, iren;

	unsigned long flags;



	nvt_dbg_verbose("%s firing", __func__);



	spin_lock_irqsave(&nvt->lock, flags);

	spin_lock(&nvt->lock);



	/*

	 * Get IR Status register contents. Write 1 to ack/clear
@@ -866,7 +865,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) 
	 * logical device is being disabled.

	 */

	if (status == 0xff && iren == 0xff) {

		spin_unlock_irqrestore(&nvt->lock, flags);

		spin_unlock(&nvt->lock);

		nvt_dbg_verbose("Spurious interrupt detected");

		return IRQ_HANDLED;

	}
@@ -875,7 +874,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) 
	 * status bit whether the related interrupt source is enabled

	 */

	if (!(status & iren)) {

		spin_unlock_irqrestore(&nvt->lock, flags);

		spin_unlock(&nvt->lock);

		nvt_dbg_verbose("%s exiting, IRSTS 0x0", __func__);

		return IRQ_NONE;

	}
@@ -923,7 +922,7 @@ static irqreturn_t nvt_cir_isr(int irq, void *data) 
		}

	}



	spin_unlock_irqrestore(&nvt->lock, flags);

	spin_unlock(&nvt->lock);



	nvt_dbg_verbose("%s done", __func__);

	return IRQ_HANDLED;