Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf9aac53 authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Greg Kroah-Hartman
Browse files

staging:rtl8187se: Change argument type in function to bool 



Since the argument morefrag is being used as a booleon in the function
rtl8180_tx, the type for the argument is changed to booleon in the
function definition and declaration. This ensures that the variable
morefrag is always in the range 0-1 and overflow dooes not cause errors
if it is assigned a value. Also, this improves code readability.

Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 43f82a6a

drivers/staging/rtl8187se/r8180.h

+1 −1
Original line number Diff line number Diff line
@@ -648,7 +648,7 @@ struct r8180_priv { 
		BE_PRIORITY)



short rtl8180_tx(struct net_device *dev, u8 *skbuf, int len, int priority,

		 short morefrag, short fragdesc, int rate);

		 bool morefrag, short fragdesc, int rate);



u8 read_nic_byte(struct net_device *dev, int x);

u32 read_nic_dword(struct net_device *dev, int x);

drivers/staging/rtl8187se/r8180_core.c

+1 −1
Original line number Diff line number Diff line
@@ -1679,7 +1679,7 @@ static void rtl8180_prepare_beacon(struct net_device *dev) 
 * it does the DMA transfer.

 */

short rtl8180_tx(struct net_device *dev, u8 *txbuf, int len, int priority,

		 short morefrag, short descfrag, int rate)

		 bool morefrag, short descfrag, int rate)

{

	struct r8180_priv *priv = ieee80211_priv(dev);

	u32 *tail, *temp_tail;