Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf6b47de authored by Jesper Juhl's avatar Jesper Juhl Committed by Roland Dreier
Browse files

IB/mlx4: Fix memory leaks in ib_link_query_port() 



If the call to mlx4_MAD_IFC() fails in ib_link_query_port() we will
currently do 'return err;' which will leak 'in_mad' and 'out_mad'.  We
should instead do 'goto out;' where we'll properly free the memory we
previously allocated.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Acked-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 00341028

drivers/infiniband/hw/mlx4/main.c

+1 −1
Original line number Diff line number Diff line
@@ -247,7 +247,7 @@ static int ib_link_query_port(struct ib_device *ibdev, u8 port, 
		err = mlx4_MAD_IFC(to_mdev(ibdev), 1, 1, port,

				   NULL, NULL, in_mad, out_mad);

		if (err)

			return err;

			goto out;



		/* Checking LinkSpeedActive for FDR-10 */

		if (out_mad->data[15] & 0x1)