Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf4407f0 authored by Antoine Tenart's avatar Antoine Tenart Committed by Herbert Xu
Browse files

crypto: inside-secure - do not use memset on MMIO 



This patch fixes the Inside Secure driver which uses a memtset() call to
set an MMIO area from the cryptographic engine to 0. This is wrong as
memset() isn't guaranteed to work on MMIO for many reasons. This led to
kernel paging request panics in certain cases. Use memset_io() instead.

Fixes: 1b44c5a6 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Reported-by: default avatarOfer Heifetz <oferh@marvell.com>
Signed-off-by: default avatarAntoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent eea0d3ea

drivers/crypto/inside-secure/safexcel.c

+2 −2
Original line number Diff line number Diff line
@@ -152,7 +152,7 @@ static int eip197_load_firmwares(struct safexcel_crypto_priv *priv) 
	       EIP197_PE_ICE_SCRATCH_CTRL_CHANGE_ACCESS;

	writel(val, EIP197_PE(priv) + EIP197_PE_ICE_SCRATCH_CTRL);



	memset(EIP197_PE(priv) + EIP197_PE_ICE_SCRATCH_RAM, 0,

	memset_io(EIP197_PE(priv) + EIP197_PE_ICE_SCRATCH_RAM, 0,

		  EIP197_NUM_OF_SCRATCH_BLOCKS * sizeof(u32));



	eip197_write_firmware(priv, fw[FW_IFPP], EIP197_PE_ICE_FPP_CTRL,