Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bed4d597 authored by Chander Kashyap's avatar Chander Kashyap Committed by Rafael J. Wysocki
Browse files

cpuidle / menu: move repeated correction factor check to init 



In menu_select function we check for correction factor every time.
If it is zero we are initializing to unity. Hence move it to init function
and initialise by unity, hence avoid repeated comparisons.

Signed-off-by: default avatarChander Kashyap <chander.kashyap@linaro.org>
Reviewed-by: default avatarTuukka Tikkanen <tuukka.tikkanen@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 3836785a

drivers/cpuidle/governors/menu.c

+8 −7
Original line number Diff line number Diff line
@@ -310,13 +310,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) 


	data->bucket = which_bucket(data->next_timer_us);



	/*

	 * if the correction factor is 0 (eg first time init or cpu hotplug

	 * etc), we actually want to start out with a unity factor.

	 */

	if (data->correction_factor[data->bucket] == 0)

		data->correction_factor[data->bucket] = RESOLUTION * DECAY;



	/*

	 * Force the result of multiplication to be 64 bits even if both

	 * operands are 32 bits.
@@ -466,9 +459,17 @@ static int menu_enable_device(struct cpuidle_driver *drv, 
				struct cpuidle_device *dev)

{

	struct menu_device *data = &per_cpu(menu_devices, dev->cpu);

	int i;



	memset(data, 0, sizeof(struct menu_device));



	/*

	 * if the correction factor is 0 (eg first time init or cpu hotplug

	 * etc), we actually want to start out with a unity factor.

	 */

	for(i = 0; i < BUCKETS; i++)

		data->correction_factor[i] = RESOLUTION * DECAY;



	return 0;

}