Commit bec145ae authored Nov 18, 2009 by Dan Carpenter Committed by Takashi Iwai Nov 18, 2009

ALSA: remove unnecessary null check



This function is only called from snd_ctl_ioctl() and the file parameter
can never be null so there is no need to check it here.

We dereference file at the start of the function:
        struct snd_card *card = file->card;
and it confuses static checkers to dereference a pointer before
checking it.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 67f2db24

sound/core/control.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1120,7 +1120,7 @@ static int snd_ctl_tlv_ioctl(struct snd_ctl_file *file,
	goto __kctl_end;		goto __kctl_end;
	}		}
	if (vd->access & SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK) {		if (vd->access & SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK) {
	if (file && vd->owner != NULL && vd->owner != file) {		if (vd->owner != NULL && vd->owner != file) {
	err = -EPERM;		err = -EPERM;
	goto __kctl_end;		goto __kctl_end;
	}		}