Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit beae9eb5 authored by Bart Van Assche's avatar Bart Van Assche Committed by Jason Gunthorpe
Browse files

RDMA/ocrdma: Make ocrdma_destroy_qp() easier to analyze 



This patch does not change any functionality but avoids that sparse
reports the following:

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1818:31: warning: context imbalance in 'ocrdma_destroy_qp' - different lock contexts for basic block

Compile-tested only.

Signed-off-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
Cc: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: Devesh Sharma <devesh.sharma@broadcom.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 07f3355d

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c

+5 −5
Original line number Diff line number Diff line
@@ -1774,13 +1774,13 @@ int ocrdma_destroy_qp(struct ib_qp *ibqp) 
	 * protect against proessing in-flight CQEs for this QP.

	 */

	spin_lock_irqsave(&qp->sq_cq->cq_lock, flags);

	if (qp->rq_cq && (qp->rq_cq != qp->sq_cq))

	if (qp->rq_cq && (qp->rq_cq != qp->sq_cq)) {

		spin_lock(&qp->rq_cq->cq_lock);



		ocrdma_del_qpn_map(dev, qp);



	if (qp->rq_cq && (qp->rq_cq != qp->sq_cq))

		spin_unlock(&qp->rq_cq->cq_lock);

	} else {

		ocrdma_del_qpn_map(dev, qp);

	}

	spin_unlock_irqrestore(&qp->sq_cq->cq_lock, flags);



	if (!pd->uctx) {