Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bea10413 authored Jun 13, 2017 by Mario Kleiner Committed by Alex Deucher Jun 14, 2017

drm/amdgpu: Fix overflow of watermark calcs at > 4k resolutions.



Commit d63c277d
("drm/amdgpu: Make display watermark calculations more accurate")
made watermark calculations more accurate, but not for > 4k
resolutions on 32-Bit architectures, as it introduced an integer
overflow for those setups and resolutions.

Fix this by proper u64 casting and division.

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Fixes: d63c277d ("drm/amdgpu: Make display watermark calculations more accurate")
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent c0f83da9

drivers/gpu/drm/amd/amdgpu/dce_v10_0.c

+5 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1207,8 +1207,11 @@ static void dce_v10_0_program_watermarks(struct amdgpu_device *adev,
	u32 tmp, wm_mask, lb_vblank_lead_lines = 0;		u32 tmp, wm_mask, lb_vblank_lead_lines = 0;

	if (amdgpu_crtc->base.enabled && num_heads && mode) {		if (amdgpu_crtc->base.enabled && num_heads && mode) {
	active_time = 1000000UL * (u32)mode->crtc_hdisplay / (u32)mode->clock;		active_time = (u32) div_u64((u64)mode->crtc_hdisplay * 1000000,
	line_time = min((u32) (1000000UL * (u32)mode->crtc_htotal / (u32)mode->clock), (u32)65535);		(u32)mode->clock);
			line_time = (u32) div_u64((u64)mode->crtc_htotal * 1000000,
			(u32)mode->clock);
			line_time = min(line_time, (u32)65535);

	/* watermark for high clocks */		/* watermark for high clocks */
	if (adev->pm.dpm_enabled) {		if (adev->pm.dpm_enabled) {

drivers/gpu/drm/amd/amdgpu/dce_v11_0.c

+5 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1176,8 +1176,11 @@ static void dce_v11_0_program_watermarks(struct amdgpu_device *adev,
	u32 tmp, wm_mask, lb_vblank_lead_lines = 0;		u32 tmp, wm_mask, lb_vblank_lead_lines = 0;

	if (amdgpu_crtc->base.enabled && num_heads && mode) {		if (amdgpu_crtc->base.enabled && num_heads && mode) {
	active_time = 1000000UL * (u32)mode->crtc_hdisplay / (u32)mode->clock;		active_time = (u32) div_u64((u64)mode->crtc_hdisplay * 1000000,
	line_time = min((u32) (1000000UL * (u32)mode->crtc_htotal / (u32)mode->clock), (u32)65535);		(u32)mode->clock);
			line_time = (u32) div_u64((u64)mode->crtc_htotal * 1000000,
			(u32)mode->clock);
			line_time = min(line_time, (u32)65535);

	/* watermark for high clocks */		/* watermark for high clocks */
	if (adev->pm.dpm_enabled) {		if (adev->pm.dpm_enabled) {

drivers/gpu/drm/amd/amdgpu/dce_v6_0.c

+5 −2

Original line number	Original line	Diff line number	Diff line
	@@ -983,8 +983,11 @@ static void dce_v6_0_program_watermarks(struct amdgpu_device *adev,
	fixed20_12 a, b, c;		fixed20_12 a, b, c;

	if (amdgpu_crtc->base.enabled && num_heads && mode) {		if (amdgpu_crtc->base.enabled && num_heads && mode) {
	active_time = 1000000UL * (u32)mode->crtc_hdisplay / (u32)mode->clock;		active_time = (u32) div_u64((u64)mode->crtc_hdisplay * 1000000,
	line_time = min((u32) (1000000UL * (u32)mode->crtc_htotal / (u32)mode->clock), (u32)65535);		(u32)mode->clock);
			line_time = (u32) div_u64((u64)mode->crtc_htotal * 1000000,
			(u32)mode->clock);
			line_time = min(line_time, (u32)65535);
	priority_a_cnt = 0;		priority_a_cnt = 0;
	priority_b_cnt = 0;		priority_b_cnt = 0;

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c

+5 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1091,8 +1091,11 @@ static void dce_v8_0_program_watermarks(struct amdgpu_device *adev,
	u32 tmp, wm_mask, lb_vblank_lead_lines = 0;		u32 tmp, wm_mask, lb_vblank_lead_lines = 0;

	if (amdgpu_crtc->base.enabled && num_heads && mode) {		if (amdgpu_crtc->base.enabled && num_heads && mode) {
	active_time = 1000000UL * (u32)mode->crtc_hdisplay / (u32)mode->clock;		active_time = (u32) div_u64((u64)mode->crtc_hdisplay * 1000000,
	line_time = min((u32) (1000000UL * (u32)mode->crtc_htotal / (u32)mode->clock), (u32)65535);		(u32)mode->clock);
			line_time = (u32) div_u64((u64)mode->crtc_htotal * 1000000,
			(u32)mode->clock);
			line_time = min(line_time, (u32)65535);

	/* watermark for high clocks */		/* watermark for high clocks */
	if (adev->pm.dpm_enabled) {		if (adev->pm.dpm_enabled) {