Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be1dc3fb authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by Tejun Heo
Browse files

pata_octeon_cf: use of_property_read_{bool|u32}() 



The Octeon CF driver basically  open-codes of_property_read_{bool|u32}()
using  of_{find|get}_property() calls in its  probe() method.  Using the
modern DT APIs saves 2 LoCs and 16 bytes of object code (MIPS gcc 3.4.3).

Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 591b6bb6

drivers/ata/pata_octeon_cf.c

+4 −6
Original line number Diff line number Diff line
@@ -840,7 +840,6 @@ static int octeon_cf_probe(struct platform_device *pdev) 
	struct property *reg_prop;

	int n_addr, n_size, reg_len;

	struct device_node *node;

	const void *prop;

	void __iomem *cs0;

	void __iomem *cs1 = NULL;

	struct ata_host *host;
@@ -850,7 +849,7 @@ static int octeon_cf_probe(struct platform_device *pdev) 
	void __iomem *base;

	struct octeon_cf_port *cf_port;

	int rv = -ENOMEM;



	u32 bus_width;



	node = pdev->dev.of_node;

	if (node == NULL)
@@ -860,11 +859,10 @@ static int octeon_cf_probe(struct platform_device *pdev) 
	if (!cf_port)

		return -ENOMEM;



	cf_port->is_true_ide = (of_find_property(node, "cavium,true-ide", NULL) != NULL);

	cf_port->is_true_ide = of_property_read_bool(node, "cavium,true-ide");



	prop = of_get_property(node, "cavium,bus-width", NULL);

	if (prop)

		is_16bit = (be32_to_cpup(prop) == 16);

	if (of_property_read_u32(node, "cavium,bus-width", &bus_width) == 0)

		is_16bit = (bus_width == 16);

	else

		is_16bit = false;