Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be19d933 authored by Julia Lawall's avatar Julia Lawall Committed by Inki Dae
Browse files

drm/exynos/ipp: fix error return code 

Propagate the returned error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent 4846e452

drivers/gpu/drm/exynos/exynos_drm_ipp.c

+3 −0
Original line number Original line Diff line number Diff line
@@ -426,18 +426,21 @@ int exynos_drm_ipp_set_property(struct drm_device *drm_dev, void *data, 
	c_node->start_work = ipp_create_cmd_work();

	c_node->start_work = ipp_create_cmd_work();

	if (IS_ERR(c_node->start_work)) {

	if (IS_ERR(c_node->start_work)) {

		DRM_ERROR("failed to create start work.\n");

		DRM_ERROR("failed to create start work.\n");

		ret = PTR_ERR(c_node->start_work);

		goto err_remove_id;

		goto err_remove_id;

	}

	}





	c_node->stop_work = ipp_create_cmd_work();

	c_node->stop_work = ipp_create_cmd_work();

	if (IS_ERR(c_node->stop_work)) {

	if (IS_ERR(c_node->stop_work)) {

		DRM_ERROR("failed to create stop work.\n");

		DRM_ERROR("failed to create stop work.\n");

		ret = PTR_ERR(c_node->stop_work);

		goto err_free_start;

		goto err_free_start;

	}

	}





	c_node->event_work = ipp_create_event_work();

	c_node->event_work = ipp_create_event_work();

	if (IS_ERR(c_node->event_work)) {

	if (IS_ERR(c_node->event_work)) {

		DRM_ERROR("failed to create event work.\n");

		DRM_ERROR("failed to create event work.\n");

		ret = PTR_ERR(c_node->event_work);

		goto err_free_stop;

		goto err_free_stop;

	}

	}