Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd368416 authored by Jian Shen's avatar Jian Shen Committed by David S. Miller
Browse files

net: hns3: check for NULL function pointer in hns3_nic_set_features 



It's necessary to check hook whether being defined before
calling, improve the reliability.

Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 181d454b

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+4 −2
Original line number Diff line number Diff line
@@ -1133,14 +1133,16 @@ static int hns3_nic_set_features(struct net_device *netdev, 
		}

	}



	if (changed & NETIF_F_HW_VLAN_CTAG_FILTER) {

	if ((changed & NETIF_F_HW_VLAN_CTAG_FILTER) &&

	    h->ae_algo->ops->enable_vlan_filter) {

		if (features & NETIF_F_HW_VLAN_CTAG_FILTER)

			h->ae_algo->ops->enable_vlan_filter(h, true);

		else

			h->ae_algo->ops->enable_vlan_filter(h, false);

	}



	if (changed & NETIF_F_HW_VLAN_CTAG_RX) {

	if ((changed & NETIF_F_HW_VLAN_CTAG_RX) &&

	    h->ae_algo->ops->enable_hw_strip_rxvtag) {

		if (features & NETIF_F_HW_VLAN_CTAG_RX)

			ret = h->ae_algo->ops->enable_hw_strip_rxvtag(h, true);

		else