Commit bc83a141 authored Apr 10, 2016 by Akinobu Mita Committed by Alexandre Belloni May 20, 2016

rtc: ds1302: fix error check in set_time

The set_time callback for rtc-ds1302 doesn't write clock registers
because the error check for the return value from spi_write_then_read()
is not correct.  spi_write_then_read() which returns zero on success.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Sergey Yanovich <ynvich@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent 05a7f27a

drivers/rtc/rtc-ds1302.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -53,7 +53,7 @@ static int ds1302_rtc_set_time(struct device dev, struct rtc_time time)

	status = spi_write_then_read(spi, buf, 2,		status = spi_write_then_read(spi, buf, 2,
	NULL, 0);		NULL, 0);
	if (!status)		if (status)
	return status;		return status;

	/* Write registers starting at the first time/date address. */		/* Write registers starting at the first time/date address. */