Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc4d45f1 authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

hwmon: (lm85) Fix error paths in probe function 

We must remove all files we created, even in error cases.

Fixes second part of kernel bug #34072:
https://bugzilla.kernel.org/show_bug.cgi?id=34072



Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
parent 5f441e22

drivers/hwmon/lm85.c

+2 −2
Original line number Diff line number Diff line
@@ -1331,11 +1331,11 @@ static int lm85_probe(struct i2c_client *client, 
	if (data->type != emc6d103s) {

		err = sysfs_create_group(&client->dev.kobj, &lm85_group_minctl);

		if (err)

			goto err_kfree;

			goto err_remove_files;

		err = sysfs_create_group(&client->dev.kobj,

					 &lm85_group_temp_off);

		if (err)

			goto err_kfree;

			goto err_remove_files;

	}



	/* The ADT7463/68 have an optional VRM 10 mode where pin 21 is used