Commit bbf360ac authored Jun 02, 2020 by Tang Bin Committed by Sasha Levin Jun 30, 2020

usb: host: ehci-exynos: Fix error check in exynos_ehci_probe()



commit 44ed240d62736ad29943ec01e41e194b96f7c5e9 upstream.

If the function platform_get_irq() failed, the negative value
returned will not be detected here. So fix error handling in
exynos_ehci_probe(). And when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant
message here.

Fixes: 1bcc5aa8 ("USB: Add initial S5P EHCI driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20200602114708.28620-1-tangbin@cmss.chinamobile.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e5e2b508

drivers/usb/host/ehci-exynos.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -188,9 +188,8 @@ static int exynos_ehci_probe(struct platform_device *pdev)
		hcd->rsrc_len = resource_size(res);

		irq = platform_get_irq(pdev, 0);
		if (!irq) {
		dev_err(&pdev->dev, "Failed to get IRQ\n");
		err = -ENODEV;
		if (irq < 0) {
		err = irq;
		goto fail_io;
		}