Commit bbdc176a authored Jan 04, 2007 by Martin Josefsson Committed by David S. Miller Jan 04, 2007

[NETFILTER]: nf_nat: fix MASQUERADE crash on device down



Check the return value of nfct_nat() in device_cmp(), we might very well
have non NAT conntrack entries as well (Netfilter bugzilla #528).

Signed-off-by: Martin Josefsson <gandalf@wlug.westbo.se>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c9386cfd

net/ipv4/netfilter/ipt_MASQUERADE.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -127,10 +127,13 @@ masquerade_target(struct sk_buff **pskb,
		static inline int
		device_cmp(struct ip_conntrack i, void ifindex)
		{
		int ret;
		#ifdef CONFIG_NF_NAT_NEEDED
		struct nf_conn_nat *nat = nfct_nat(i);

		if (!nat)
		return 0;
		#endif
		int ret;

		read_lock_bh(&masq_lock);
		#ifdef CONFIG_NF_NAT_NEEDED