Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit baee502c authored by Ralf Baechle's avatar Ralf Baechle
Browse files

Get rid of the eir struct mips_fpu_emulator_private member. It's 


never initialized been initialized anywhere, just saved to and
restored from signal frames so nonsense anyway.  As neat side effect
of being shared between all processors it was also abusable as a
nice covert channel between processes.

Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 1d74f6bc

arch/mips/math-emu/kernel_linkage.c

+0 −4
Original line number Diff line number Diff line
@@ -63,7 +63,6 @@ int fpu_emulator_save_context(struct sigcontext *sc) 
			       &sc->sc_fpregs[i]);

	}

	err |= __put_user(current->thread.fpu.soft.fcr31, &sc->sc_fpc_csr);

	err |= __put_user(fpuemuprivate.eir, &sc->sc_fpc_eir);



	return err;

}
@@ -79,7 +78,6 @@ int fpu_emulator_restore_context(struct sigcontext *sc) 
			       &sc->sc_fpregs[i]);

	}

	err |= __get_user(current->thread.fpu.soft.fcr31, &sc->sc_fpc_csr);

	err |= __get_user(fpuemuprivate.eir, &sc->sc_fpc_eir);



	return err;

}
@@ -100,7 +98,6 @@ int fpu_emulator_save_context32(struct sigcontext32 *sc) 
			       &sc->sc_fpregs[i]);

	}

	err |= __put_user(current->thread.fpu.soft.fcr31, &sc->sc_fpc_csr);

	err |= __put_user(fpuemuprivate.eir, &sc->sc_fpc_eir);



	return err;

}
@@ -116,7 +113,6 @@ int fpu_emulator_restore_context32(struct sigcontext32 *sc) 
			       &sc->sc_fpregs[i]);

	}

	err |= __get_user(current->thread.fpu.soft.fcr31, &sc->sc_fpc_csr);

	err |= __get_user(fpuemuprivate.eir, &sc->sc_fpc_eir);



	return err;

}

include/asm-mips/fpu_emulator.h

+0 −1
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ 
#define _ASM_FPU_EMULATOR_H



struct mips_fpu_emulator_private {

	unsigned int eir;

	struct {

		unsigned int emulated;

		unsigned int loads;