Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bae94dc3 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] cx231xx-417: Fix a gcc warning 



gcc didn't like to have i++ inside a complex operation:

drivers/media/video/cx231xx/cx231xx-417.c: In function ‘cx231xx_load_firmware’:
drivers/media/video/cx231xx/cx231xx-417.c:1059: warning: operation on ‘i’ may be undefined
drivers/media/video/cx231xx/cx231xx-417.c:1061: warning: operation on ‘i’ may be undefined
drivers/media/video/cx231xx/cx231xx-417.c:1063: warning: operation on ‘i’ may be undefined

Btw, I agree with gcc, as we're using i and i++ at the same operation and,
depending on how optimization may occur, it may produce a wrong code.

While here, fix CodingStyle issues on the changed code.

Acked-by: default avatarSri Deevi <Srinivasa.Deevi@conexant.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 955e6ed8

drivers/media/video/cx231xx/cx231xx-417.c

+8 −9
Original line number Diff line number Diff line
@@ -1055,14 +1055,13 @@ static int cx231xx_load_firmware(struct cx231xx *dev) 
	for (frame = 0; frame < (int)(CX231xx_FIRM_IMAGE_SIZE*20/_buffer_size);

	     frame++) {

		for (i = 0; i < _buffer_size; i++) {

			*(p_buffer+i) =

			(u8)(*(p_fw+(frame*128*8+(i++/4))) & 0x000000FF);

			*(p_buffer+i) =

			(u8)((*(p_fw+(frame*128*8+(i++/4))) & 0x0000FF00)>>8);

			*(p_buffer+i) =

			(u8)((*(p_fw+(frame*128*8+(i++/4))) & 0x00FF0000)>>16);

			*(p_buffer+i) =

			(u8)((*(p_fw+(frame*128*8+(i/4))) & 0xFF000000)>>24);

			*(p_buffer + i) = (u8)(*(p_fw + (frame * 128 * 8 + (i / 4))) & 0x000000FF);

			i++;

			*(p_buffer + i) = (u8)((*(p_fw + (frame * 128 * 8 + (i / 4))) & 0x0000FF00) >> 8);

			i++;

			*(p_buffer + i) = (u8)((*(p_fw + (frame * 128 * 8 + (i / 4))) & 0x00FF0000) >> 16);

			i++;

			*(p_buffer + i) = (u8)((*(p_fw + (frame * 128 * 8 + (i / 4))) & 0xFF000000) >> 24);

		}

		cx231xx_ep5_bulkout(dev, p_buffer, _buffer_size);

	}