Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit baae03a0 authored by Anup Patel's avatar Anup Patel Committed by Vinod Koul
Browse files

async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() 



The DMA_PREP_FENCE is to be used when preparing Tx descriptor if output
of Tx descriptor is to be used by next/dependent Tx descriptor.

The DMA_PREP_FENSE will not be set correctly in do_async_gen_syndrome()
when calling dma->device_prep_dma_pq() under following conditions:
1. ASYNC_TX_FENCE not set in submit->flags
2. DMA_PREP_FENCE not set in dma_flags
3. src_cnt (= (disks - 2)) is greater than dma_maxpq(dma, dma_flags)

This patch fixes DMA_PREP_FENCE usage in do_async_gen_syndrome() taking
inspiration from do_async_xor() implementation.

Signed-off-by: default avatarAnup Patel <anup.patel@broadcom.com>
Reviewed-by: default avatarRay Jui <ray.jui@broadcom.com>
Reviewed-by: default avatarScott Branden <scott.branden@broadcom.com>
Acked-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent b5dceda1

crypto/async_tx/async_pq.c

+2 −3
Original line number Diff line number Diff line
@@ -62,9 +62,6 @@ do_async_gen_syndrome(struct dma_chan *chan, 
	dma_addr_t dma_dest[2];

	int src_off = 0;



	if (submit->flags & ASYNC_TX_FENCE)

		dma_flags |= DMA_PREP_FENCE;



	while (src_cnt > 0) {

		submit->flags = flags_orig;

		pq_src_cnt = min(src_cnt, dma_maxpq(dma, dma_flags));
@@ -83,6 +80,8 @@ do_async_gen_syndrome(struct dma_chan *chan, 
			if (cb_fn_orig)

				dma_flags |= DMA_PREP_INTERRUPT;

		}

		if (submit->flags & ASYNC_TX_FENCE)

			dma_flags |= DMA_PREP_FENCE;



		/* Drivers force forward progress in case they can not provide

		 * a descriptor