Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba8afe94 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mark Brown
Browse files

spi/bcm63xx: fix error return code in bcm63xx_spi_probe() 

platform_get_irq() returns an error code, but the spi-bcm63xx driver
ignores it and always returns -ENXIO. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af



Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5771a8c0

drivers/spi/spi-bcm63xx.c

+2 −2
Original line number Diff line number Diff line
@@ -530,8 +530,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) 


	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(dev, "no irq\n");

		return -ENXIO;

		dev_err(dev, "no irq: %d\n", irq);

		return irq;

	}



	clk = devm_clk_get(dev, "spi");